Code & list formatting in the readme#57
Open
NickVolynkin wants to merge 1 commit intofoliant-docs:developfrom
Open
Code & list formatting in the readme#57NickVolynkin wants to merge 1 commit intofoliant-docs:developfrom
NickVolynkin wants to merge 1 commit intofoliant-docs:developfrom
Conversation
* Make code examples a part of list items. Before now, they were outside of the ordered list structure. * Use `console` as the lexer for code examples having both command and output lines. See https://pygments.org/docs/lexers/#pygments.lexers.shell.BashSessionLexer
|
@NickVolynkin Thanks for the PR!
Unfortunately, this won't work due to MkDocs limitations: https://foliant-docs.github.io/docs/backends/mkdocs/#fenced-code-is-not-rendered-in-list-items-or-blockquotes Please revert this change. |
moigagoo
requested changes
Nov 27, 2020
| ───────────────────── | ||
| Project "Hello Foliant" created in /path/to/hello-foliant | ||
| ``` | ||
| ```console |
There was a problem hiding this comment.
Please revert, fenced code blocks are not supported in lists: https://foliant-docs.github.io/docs/backends/mkdocs/#fenced-code-is-not-rendered-in-list-items-or-blockquotes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make code examples a part of list items. Before now, they were outside of the ordered list structure.
Use
consoleas the lexer for code examples having both command and output lines.See https://pygments.org/docs/lexers/#pygments.lexers.shell.BashSessionLexer